Agent Review should use git merge-base

Feature request for product/service

Cursor IDE

Describe the request

When using Agent Review, it seems to compare against the latest main (or master? I can’t even tell that) branch.
However, my PR is not always rebased, leading to a lot of irrelevant files showing up in the review.
Can you make it possible to choose the branch, and use git merge-base to get the relevant commit, instead of the latest?

1 Like

+1
master in unusable for me in my work environment. Most companies have dev/staging/qa/etc.

+1 must add

Great feedback! Relaying

Hey folks! I’m a bit confused with this feature request. In the newest version of our Review feature, you can already choose the base branch when performing a comparison, and when choosing a base branch, we find the merge base to ensure we’re only diffing relevant changes for your branch. Is this not working for you?

1 Like

I’m on the latest version (just ran “check for updates” to make sure) and I don’t see this option:

Yes this is perfect, hope it reaches public versions soon!

a question regarding this - does it diff against the tip of the branch, or the branch-point? I’d prefer to be able to diff against the merge-base because that way it only includes my changes, and not code that was added to the main branch later.

I hope my explanation is clear.

Any update on this? This is still not in the latest version, what happened?

can we get this implemented please??? still not present in 2.3.20