I don't like the new cursor diff view

When I click on the edited file in cursor in the agent panel, in the newest update it goes to the diff view instead of the file itself. The whole point of seeing where the changes are is to be able to accept a change, see how it fits into the surrounding code context, and then make edits if necessary. Instead, when I accept a change now, the changes and file disappear from the diff view.

This has ruined my experience in cursor. Can I disable this setting?

23 Likes

I 100% agree… I need to see more context when I’m evaluating a change.

I don’t always evaluate all changes… many I just “trust” and test the outcome. But when I do evaluate (usually data model changes, or very specific businss logic)… I always want to have quick access to the entire file contents.

I much preferred the previous “Next File” system. With the new system there are too many clicks required to get there… and then when I “approve” the changed file is removed from the list in the chat panel, so I can’t quickly get back to it.

Please make the default mode of review a configurable option!

4 Likes

Fully agree here. The new default consolidated diff tool/view that shows all the files with all changes, does not show the same details as the previous per-file approach. I don’t like it, and it has just complicated the process of reviewing changes I have to open the new diff view, find the file I need to review, click the filename to open the file itself in diff mode, so I can see the ACTUAL changes of interest.

One of the biggest issues with the diff view, and why it is NOT a viable default view, is that it shows all changes from the beginning of changes to those files, consolidated. In some cases, for files that were originally created new at the beginning of the chat, but have had progressive refinements over time, the consolidated diff view just shows that the entire file and all its contents are new. There is no way to see the changes over time to the file so you can properly review PROGRESSIVE refinements.

However I review as I go, not once at the very end of the work for a given chat, and I will accept/undo as I go. This means that every time I click a file to review, I get the new consolidated diff tool, which shows ALL the changes from the beginning consolidated, rather than just the most recent changes. I’ve gone from one-click access to being able to review the changes in the files I need to review, to having to click multiple times as well as scroll to hunt for the file in question via the consolidated diff view.

Very annoying and frustrating. Another one of those one step forward, many steps back changes with Cursor recently that have reduced the quality of the product.

1 Like

some changes on a lot of files where only a couple of lines dont tell me any if i only see that lines, i need to review what is doing not just make blind accept and see only a few lines of the file dont tell me nothing

1 Like

Someone needs to address this, I’m going crazy. These guys are breaking the workflows of their user with no concern or empathy

3 Likes

This is actually unbearable in several ways. You can’t do anything while Agent is running because it switches your tab every 10 seconds

Hey all - we are going to make command/ctrl clicking on the file open it instead of the review pane

3 Likes

Thank you, that’s great to hear! Also, will there be an option/setting to not follow the tab of the Agent as it makes changes?

Not sure about this yet - prefer to do click/cmd click so we can support both!

Thank you! Is this live already in the latest update ? Let us know what version this has been fixed it. I was so thrown off 2 days ago because of this. I’m not even sure how this passed your QA. v v bad design decision

@andrewh I have been noticing performance issues with Cursor lately. Its notable when typing in the prompt input, and the rendering of what I am typing lags behind what I’ve actually typed as it appears on screen.

I was not sure what was causing the issue before, and I have been closing other apps, closing my browser, everything, trying to figure out what was causing the lag. IT has been particularly severe today. I’ve been cycling through a LOT of work today, so maybe I just have a higher volume of changes, I am not sure, but, I finally figured out the cause of the lag:

This new diff view!

When the diff view is open, even if it is not the foreground tab, it seems to cause lag throughout cursor. Closing the diff view tab, and cursor speeds right up again.

FWIW, the above issue, seems to be a cumulative issue. If I close and restart Cursor, initially, its fine, and the diff view doesn’t cause problems. Throughout the day, though, the problem begins to appear and eventually gets quite severe. I am not sure it is solely related to the diff view, although having it open definitely makes things worse. By the end of each day, cursor is practically impossible to use if I don’t close and restart it. I wonder if there is something about accumulated change detection/diff processing, that maybe isn’t getting freed up properly as changes are accepted? I’ve noticed that if I accept the last change from the last prompt, the diff view changes and displays ALL the changes from ALL the files I’ve changed as part of that chat, so clearly, those details are not getting cleared out of memory and persist long, long after I’ve completed that work and moved on to something else. So I wonder if there is, in a sense, a memory leak here, with massive amounts of accumulating diffs throughout the day? With an agent, you can really crank through a massive amount of change in a day, and having Cursor hold on to all the diffs for all changes, seems rather impractical.

I don’t find a lot of value in the diff view anyway. It is inconsistent in how it shows diffs vs. the individual file view we have had since the beginning. I think that the diff view, shows you the accumulated diff from the beginning of the chat, which is actually rather problematic as your work progresses through a chat. You might initially create some new files or do some bulk changes to existing files (or both), but then as you debug, refine, optimize and finalize, and make additional changes, these individual changes are not reflected in the diff view tool. If you had a new file, the whole file is diffed as a new file in the diff view, always. So if you initially accept that new file, then fix a bug in it later, the bug may have affected just a few lines. When you go to review the changes relative to the fix for that bug…the diff view is 100% useless. I no longer trust that the diff view is ever showing me the correct diff, so I am now always having to click into the diff view, then click into the individual files from the diff view, in order to see the REAL diff for my last prompt. Has definitely increased the effort to review changes.

Would be really nice to be able to just disable the diff view entirely…between the performance issue it seems to impose by holding on to diff information, and the fact that at least with my workflow it is for all intents and purposes entirely useless, I would rather have an option to just go back to how things worked before, and not bother with the diff view or the performance impact it imposes at all.

FYI this is not working for me in the latest update.

also, I would suggest that the DEFAULT be reverted to the original behavior and open the individually clicked on file, and let CMD click implement the new feature and open the new “review” mode.

Or, over a separate link altogether that opens the review mode.

1 Like

Doesn’t seem to be working.

Also, you are acting like:

  1. Creating a problem
  2. Fixing it by creating another problem

Keep whatever we had originally. If you need to â– â– â– â– â– â–  then atleast add a settings so that user can control what they want.

2 Likes

I deeply regret turning this feature on.

How do I turn this off?!

It’s KILLING my productivity.

I don’t have a monster size screen. And the agents keep getting stuck asking me to review things in panes I can’t even see.

In case you don’t know how I feel about this,
I have provided this explainer diagram: :backhand_index_pointing_down:

What does “Commit” even mean here? Is it going to do a git operation? Or does this mean I am accepting the agent’s changes into the filesystem? I dare not press commit, in case it does some git kung fu that borks my client repo and breaks things I haven’t pushed yet.

If I X out of the the review (Cmd + W), do my changes then disappear from the filesystem and the agent has to rebuild them again? Using extra tokens for nothing?

I can’t tell if I’m reviewing agent changes, or if I’m reviewing git changes, or if I’m doing both.

I don’t know what happened, or if I’m even talking about the same feature as you guys, but in the last few days I clicked, ~ ”sure i would love to try the new review thing”. And ever since then - Cursor has violently abused my cognitive load all day, every day with this tiresome BS.

Apart from that, great app :+1:

3 Likes

You should have a config to turn off the review mode, instead of adding just another binding.

For me “cursor.inlineDiff.mode”: “unified” is making it usable

2 Likes

It’s indeed annoying. I found a way to disable it. Cursor Setting → Agents → Inline Editing & Terminal → Inline Diff Mode → Unified
Then it goes aways

1 Like

Hey all - deeply apologize - we’ve heard the feedback and are restoring the onclick behavior to open files directly. As well as restoring the keep/undo buttons from check/x to be more prominent.

3 Likes

Seems better, but a couple details still less than optimal IMHO:

  • The file list in the chat panel collapses when I click “Keep All”
    • I’d prefer that not happen, as I didn’t click to collapse, I clicked to accept the changes.
    • I can easily click once more if I want to collapse, but usually I don’t because I want to inspect something.
  • After keeping all, moving my mouse down, and re-opening the collapsed panel:
    • Now when I click on the accepted files it’s back to the old behavior of defaulting to “Review” mode!
    • Even CMD-Click does not work from this list after accepting changes!